]> git.ipfire.org Git - people/ms/linux.git/commit
ext4: Fix block zeroing when punching holes in indirect block files
authorJan Kara <jack@suse.cz>
Thu, 26 Jun 2014 16:28:57 +0000 (12:28 -0400)
committerJiri Slaby <jslaby@suse.cz>
Tue, 26 Aug 2014 12:12:06 +0000 (14:12 +0200)
commit056a01ab3c65605a16aa4841de0530d9d3d66b9f
treef9897ddaf8835fee6e0532a1ab16b883a65e9f96
parent8b18c0adbc5d0cb1530692e72bcfb88fd7bb77bb
ext4: Fix block zeroing when punching holes in indirect block files

commit 77ea2a4ba657a1ad4fb7c64bc5cdce84b8a132b6 upstream.

free_holes_block() passed local variable as a block pointer
to ext4_clear_blocks(). Thus ext4_clear_blocks() zeroed out this local
variable instead of proper place in inode / indirect block. We later
zero out proper place in inode / indirect block but don't dirty the
inode / buffer again which can lead to subtle issues (some changes e.g.
to inode can be lost).

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
fs/ext4/indirect.c