]> git.ipfire.org Git - thirdparty/qemu.git/commit
ui/gtk: fix "Copy" menu item segfault
authorStefan Hajnoczi <stefanha@redhat.com>
Wed, 14 Dec 2016 14:25:18 +0000 (14:25 +0000)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Wed, 21 Dec 2016 01:31:47 +0000 (19:31 -0600)
commit05838b4688393f3cf9949aa1f707a35618b725c6
treeb79e70eec077850a680a5c1f63682b1d4fd76b4c
parent223d1a2da1713adba84115150bd59bd2f9d06866
ui/gtk: fix "Copy" menu item segfault

The "Copy" menu item copies VTE terminal text to the clipboard.  This
only works with VTE terminals, not with graphics consoles.

Disable the menu item when the current notebook page isn't a VTE
terminal.

This patch fixes a segfault.  Reproducer: Start QEMU and click the Copy
menu item when the guest display is visible.

Reported-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20161214142518.10504-1-stefanha@redhat.com
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
(cherry picked from commit a08156321ab9a7d2fed9ee77dbfeea2a61ffd153)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
ui/gtk.c