]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Call migrate-incoming with exit-on-error=false
authorJiri Denemark <jdenemar@redhat.com>
Tue, 10 Dec 2024 11:28:53 +0000 (12:28 +0100)
committerJiri Denemark <jdenemar@redhat.com>
Thu, 19 Dec 2024 14:21:21 +0000 (15:21 +0100)
commit060fd63c261b596c10a4cf84c7021ec5c0b71a2a
treeb5aba8f323ea551f4f1d21681561043da06535e2
parent090a2f27c21b6a919dd72b21d852989b1942bb3a
qemu: Call migrate-incoming with exit-on-error=false

The exit-on-error=false argument of migrate-incoming tells the QEMU
process to keep running when incoming migration fails, which helps us in
two ways:

1. When migration enters Finish phase to cleanup the process, the domain
   might not even exist on the destination (because it has already been
   cleaned up by EOF monitor callback) and we would get rather unhelpful
   "operation failed: domain is no longer running" error message.

2. We can get the error that caused incoming migration to fail directly
   from QEMU via query-migrate QMP command.

https://issues.redhat.com/browse/RHEL-7041

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_migration.c
src/qemu/qemu_monitor.c
src/qemu/qemu_monitor.h
src/qemu/qemu_monitor_json.c
src/qemu/qemu_monitor_json.h