]> git.ipfire.org Git - thirdparty/linux.git/commit
perf/hw_breakpoint: Return EOPNOTSUPP for unsupported breakpoint type
authorSaket Kumar Bhaskar <skb99@linux.ibm.com>
Mon, 3 Mar 2025 09:24:51 +0000 (14:54 +0530)
committerIngo Molnar <mingo@kernel.org>
Tue, 4 Mar 2025 08:42:13 +0000 (09:42 +0100)
commit061c991697062f3bf87b72ed553d1d33a0e370dd
treea01630251828593e712780c3fc9f5defa6a15ffc
parentef2f798600313291c3726522d5c66abf89361e94
perf/hw_breakpoint: Return EOPNOTSUPP for unsupported breakpoint type

Currently, __reserve_bp_slot() returns -ENOSPC for unsupported
breakpoint types on the architecture. For example, powerpc
does not support hardware instruction breakpoints. This causes
the perf_skip BPF selftest to fail, as neither ENOENT nor
EOPNOTSUPP is returned by perf_event_open for unsupported
breakpoint types. As a result, the test that should be skipped
for this arch is not correctly identified.

To resolve this, hw_breakpoint_event_init() should exit early by
checking for unsupported breakpoint types using
hw_breakpoint_slots_cached() and return the appropriate error
(-EOPNOTSUPP).

Signed-off-by: Saket Kumar Bhaskar <skb99@linux.ibm.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Marco Elver <elver@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Link: https://lore.kernel.org/r/20250303092451.1862862-1-skb99@linux.ibm.com
kernel/events/hw_breakpoint.c