]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: set tap device online for type='ethernet'
authorLaine Stump <laine@laine.org>
Thu, 25 Aug 2016 05:46:37 +0000 (01:46 -0400)
committerLaine Stump <laine@laine.org>
Thu, 25 Aug 2016 22:54:01 +0000 (18:54 -0400)
commit07262221234af0902cc649c1c991e8f11fa350d9
treefe7e629f691edd24d04ef1a2de1dae17fdf7eec9
parentdbb790393293b9cb9597d5e230ea595088a26126
qemu: set tap device online for type='ethernet'

When support for auto-creating tap devices was added to <interface
type='ethernet'> in commit 9c17d6, the code assumed that
virNetDevTapCreate() would honor the VIR_NETDEV_TAP__CREATE_IFUP flag
that is supported by virNetDevTapCreateInBridgePort(). That isn't the
case - the latter function performs several operations, and one of
them is setting the tap device online. But virNetDevTapCreate() *only*
creates the tap device, and relies on the caller to do everything
else, so qemuInterfaceEthernetConnect() needs to call
virNetDevSetOnline() after the device is successfully created.
src/qemu/qemu_interface.c