]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
xhci: Fix Link TRB DMA in command ring stopped completion event
authorFaisal Hassan <quic_faisalh@quicinc.com>
Tue, 22 Oct 2024 15:56:31 +0000 (21:26 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 29 Oct 2024 03:23:59 +0000 (04:23 +0100)
commit075919f6df5dd82ad0b1894898b315fbb3c29b84
treecad1762787a5df9b5bcc7141c9310129bbbdbca7
parent31004740e42846a6f0bb255e6348281df3eb8032
xhci: Fix Link TRB DMA in command ring stopped completion event

During the aborting of a command, the software receives a command
completion event for the command ring stopped, with the TRB pointing
to the next TRB after the aborted command.

If the command we abort is located just before the Link TRB in the
command ring, then during the 'command ring stopped' completion event,
the xHC gives the Link TRB in the event's cmd DMA, which causes a
mismatch in handling command completion event.

To address this situation, move the 'command ring stopped' completion
event check slightly earlier, since the specific command it stopped
on isn't of significant concern.

Fixes: 7f84eef0dafb ("USB: xhci: No-op command queueing and irq handler.")
Cc: stable@vger.kernel.org
Signed-off-by: Faisal Hassan <quic_faisalh@quicinc.com>
Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20241022155631.1185-1-quic_faisalh@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-ring.c