]> git.ipfire.org Git - thirdparty/qemu.git/commit
exec: fix TB invalidation after breakpoint insertion/deletion
authorMax Filippov <jcmvbkbc@gmail.com>
Sun, 27 May 2012 16:21:08 +0000 (20:21 +0400)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 25 Jun 2012 13:48:46 +0000 (08:48 -0500)
commit07ff37597bee726681c94c650568870bd4ff94d1
tree6b7e2ff82769e4c51a06dcf70728508fc641cf6f
parente77326d99c938d78a06036b8529b669253baec59
exec: fix TB invalidation after breakpoint insertion/deletion

tb_invalidate_phys_addr has to be called with the exact physical address of
the breakpoint we add/remove, not just the page's base address.
Otherwise we easily fail to flush the right TB.

This breakage was introduced by the commit f3705d5329 "memory: make
phys_page_find() return an unadjusted".

This appeared to work for some guest architectures because their
cpu_get_phys_page_debug implementation returns full translated physical
address, not just the base of the TARGET_PAGE_SIZE-sized page.

Reported-by: TeLeMan <geleman@gmail.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
(cherry picked from commit 9d70c4b7b8a580959cc4f739e7c9a04964d00d46)

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
exec.c