]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: renesas_usbhs: gadget: Fix usb_ep_set_{halt,wedge}() behavior
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Tue, 1 Oct 2019 10:10:33 +0000 (19:10 +0900)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 19 Dec 2019 15:58:08 +0000 (15:58 +0000)
commit080c32c9438b4269d9549fea5f7d5476af107e12
treef2de1c21df901bad9cfcaf61dfdd2384f5738aeb
parent333fe262de5949c5b9f4131892a3969561dad9c3
usb: renesas_usbhs: gadget: Fix usb_ep_set_{halt,wedge}() behavior

commit 4d599cd3a097a85a5c68a2c82b9a48cddf9953ec upstream.

According to usb_ep_set_halt()'s description,
__usbhsg_ep_set_halt_wedge() should return -EAGAIN if the IN endpoint
has any queue or data. Otherwise, this driver is possible to cause
just STALL without sending a short packet data on g_mass_storage driver,
and then a few resetting a device happens on a host side during
a usb enumaration.

Fixes: 2f98382dcdfe ("usb: renesas_usbhs: Add Renesas USBHS Gadget")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Link: https://lore.kernel.org/r/1569924633-322-3-git-send-email-yoshihiro.shimoda.uh@renesas.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/renesas_usbhs/common.h
drivers/usb/renesas_usbhs/fifo.c
drivers/usb/renesas_usbhs/fifo.h
drivers/usb/renesas_usbhs/mod_gadget.c
drivers/usb/renesas_usbhs/pipe.c
drivers/usb/renesas_usbhs/pipe.h