]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
perf/x86/amd: fix potential integer overflow on shift of a int
authorColin Ian King <colin.i.king@gmail.com>
Fri, 2 Dec 2022 13:51:49 +0000 (13:51 +0000)
committerPeter Zijlstra <peterz@infradead.org>
Tue, 27 Dec 2022 11:44:00 +0000 (12:44 +0100)
commit08245672cdc6505550d1a5020603b0a8d4a6dcc7
tree98a01f344a7b4888c3247ae02b5329a486883a5b
parentf841b682baef90ee144df8b12e2c76aa460717c1
perf/x86/amd: fix potential integer overflow on shift of a int

The left shift of int 32 bit integer constant 1 is evaluated using 32 bit
arithmetic and then passed as a 64 bit function argument. In the case where
i is 32 or more this can lead to an overflow.  Avoid this by shifting
using the BIT_ULL macro instead.

Fixes: 471af006a747 ("perf/x86/amd: Constrain Large Increment per Cycle events")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Ian Rogers <irogers@google.com>
Acked-by: Kim Phillips <kim.phillips@amd.com>
Link: https://lore.kernel.org/r/20221202135149.1797974-1-colin.i.king@gmail.com
arch/x86/events/amd/core.c