]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
vfs: dodge smp_mb in break_lease and break_deleg in the common case
authorMateusz Guzik <mjguzik@gmail.com>
Tue, 6 Aug 2024 17:28:46 +0000 (19:28 +0200)
committerChristian Brauner <brauner@kernel.org>
Fri, 30 Aug 2024 06:22:33 +0000 (08:22 +0200)
commit087adb4f0f91ee330446a70af899e6a996e5cc13
treee087a606f59ceef5add818265921dea4f587c7de
parent215ab0d8af59cfc394fa83a702f0af21a5e126c7
vfs: dodge smp_mb in break_lease and break_deleg in the common case

These inlines show up in the fast path (e.g., in do_dentry_open()) and
induce said full barrier regarding i_flctx access when in most cases the
pointer is NULL.

The pointer can be safely checked before issuing the barrier, dodging it
in most cases as a result.

It is plausible the consume fence would be sufficient, but I don't want
to go audit all callers regarding what they before calling here.

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Link: https://lore.kernel.org/r/20240806172846.886570-1-mjguzik@gmail.com
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
include/linux/filelock.h