]> git.ipfire.org Git - thirdparty/hostap.git/commit
mka: Fix getting capabilities from the driver
authorSabrina Dubroca <sd@queasysnail.net>
Tue, 15 Nov 2016 17:06:23 +0000 (18:06 +0100)
committerJouni Malinen <j@w1.fi>
Sat, 19 Nov 2016 15:29:54 +0000 (17:29 +0200)
commit088d53dd15b14a1868b70fd0b8d695ac6b68f642
tree6db1f1f9c7f92ceb39ac6a266f19343901dbc70c
parent242fc738a057ffd884aca2990af4fdd60746fc64
mka: Fix getting capabilities from the driver

In commit a25e4efc9e428d968e83398bd8c9c94698ba5851 ('mka: Add driver op
to get macsec capabilities') I added some code to check the driver's
capabilities. This commit has two problems:
 - wrong enum type set in kay->macsec_confidentiality
 - ignores that drivers could report MACSEC_CAP_NOT_IMPLEMENTED, in
   which case the MKA would claim that MACsec is supported.

Fix this by interpreting MACSEC_CAP_NOT_IMPLEMENTED in the same way as a
DO_NOT_SECURE policy, and set the correct value in
kay->macsec_confidentiality.

Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
src/pae/ieee802_1x_kay.c