]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
scsi: bnx2fc: Fix skb double free in bnx2fc_rcv()
authorWei Yongjun <weiyongjun1@huawei.com>
Mon, 14 Nov 2022 11:06:26 +0000 (11:06 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 19 Dec 2023 01:29:53 +0000 (20:29 -0500)
commit08c94d80b2da481652fb633e79cbc41e9e326a91
treef4094790e2b1b705c22d419e080034b2bc0e1579
parent77a67255609606164e1042f3bf7452a568a700e4
scsi: bnx2fc: Fix skb double free in bnx2fc_rcv()

skb_share_check() already drops the reference to the skb when returning
NULL. Using kfree_skb() in the error handling path leads to an skb double
free.

Fix this by removing the variable tmp_skb, and return directly when
skb_share_check() returns NULL.

Fixes: 01a4cc4d0cd6 ("bnx2fc: do not add shared skbs to the fcoe_rx_list")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20221114110626.526643-1-weiyongjun@huaweicloud.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/bnx2fc/bnx2fc_fcoe.c