]> git.ipfire.org Git - thirdparty/openvpn.git/commit
openvpnmsica: remove OpenVPNService state check code
authorLev Stipakov <lev@openvpn.net>
Thu, 28 Jul 2022 11:17:12 +0000 (14:17 +0300)
committerGert Doering <gert@greenie.muc.de>
Sat, 6 Aug 2022 10:47:22 +0000 (12:47 +0200)
commit08d393d4f17ec645450b245756c2429c8fa1fcec
treec0c17e040bd1a1f42a0703b5e64b48926dbb4447
parenta9b3585d606e5b5717778777a4f346c8371d2698
openvpnmsica: remove OpenVPNService state check code

This code reads the state of OpenVPNService,
such as startup mode and running, and sets MSI
property value. If that property is set, installer
selects OpenVPNService as a feature to be installed.

This has been superseded by change in installer:

  https://github.com/OpenVPN/openvpn-build/pull/261

which, in addition to checking the state of OpenVPNService,
applies that state to the newly installed service.

  - by default, OpenVPNService feature is now checked
and service is installed

  - in clean installation, service startup mode is set to "manual"
and service is not started

  - in upgrade, installer preserves the service state, such
as startup mode and started/stopped

With all those changes to installer, we don't need this code
in openvpnmsica.

Signed-off-by: Lev Stipakov <lev@openvpn.net>
Acked-by: Selva Nair <selva.nair@gmail.com>
Message-Id: <20220728111712.94-1-lstipakov@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24752.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpnmsica/openvpnmsica.c