]> git.ipfire.org Git - thirdparty/gcc.git/commit
Fix omp-low ICE for indirect references based off component access [PR103642]
authorChung-Lin Tang <cltang@codesourcery.com>
Thu, 27 Jan 2022 10:33:00 +0000 (18:33 +0800)
committerChung-Lin Tang <cltang@codesourcery.com>
Thu, 27 Jan 2022 10:45:21 +0000 (18:45 +0800)
commit090bd2c50bc7987644c4b2eba76a310134475842
treec2cdf49e4339f90e3fb264eed0c37d968ec18f64
parent96a3b111881df93861a69b98d6fd9ac1b0f94999
Fix omp-low ICE for indirect references based off component access [PR103642]

This issue was triggered after the patch extending syntax for component access
in map clauses in commit 0ab29cf0bb68960c1f87405f14b4fb2109254e2f.

In gimplify_scan_omp_clauses, the case for handling indirect accesses (which
creates firstprivate ptr and zero-length array section map for such decls) was
erroneously went into for non-pointer cases (here being the base struct decl),
so added the
appropriate checks there.

Added new testcase is a compile only test for the ICE. The original omptests
t-partial-struct test actually should not execute correctly, because for
map(t.s->a[:N]), map(t.s[:1]) is not implicitly mapped, thus the entire
offloaded access does not work as is (fixing that omptests test is out of
scope here).

2022-01-27  Chung-Lin Tang  <cltang@codesourcery.com>

PR middle-end/103642

gcc/ChangeLog:

* gimplify.cc (gimplify_scan_omp_clauses): Do not do indir_p handling
for non-pointer or non-reference-to-pointer cases.

gcc/testsuite/ChangeLog:

* c-c++-common/gomp/pr103642.c: New test.

(cherry picked from commit 1c91b014923f418e0aab789c5cf57facf04bf266)
gcc/gimplify.c
gcc/testsuite/c-c++-common/gomp/pr103642.c [new file with mode: 0644]