]> git.ipfire.org Git - thirdparty/qemu.git/commit
target/arm: arm_reset_sve_state() should set FPSR, not FPCR
authorPeter Maydell <peter.maydell@linaro.org>
Fri, 24 Jan 2025 16:27:23 +0000 (16:27 +0000)
committerMichael Tokarev <mjt@tls.msk.ru>
Wed, 29 Jan 2025 19:25:22 +0000 (22:25 +0300)
commit09537fbd34736f39b49bce805e04dc6f12d7ce89
tree7b2dc726538d14fda2880cd7574ff3e87e9174ce
parent7594c49b95453c085d4da3903e6ffb79bae07c50
target/arm: arm_reset_sve_state() should set FPSR, not FPCR

The pseudocode ResetSVEState() does:
    FPSR = ZeroExtend(0x0800009f<31:0>, 64);
but QEMU's arm_reset_sve_state() called vfp_set_fpcr() by accident.

Before the advent of FEAT_AFP, this was only setting a collection of
RES0 bits, which vfp_set_fpsr() would then ignore, so the only effect
was that we didn't actually set the FPSR the way we are supposed to
do.  Once FEAT_AFP is implemented, setting the bottom bits of FPSR
will change the floating point behaviour.

Call vfp_set_fpsr(), as we ought to.

(Note for stable backports: commit 7f2a01e7368f9 moved this function
from sme_helper.c to helper.c, but it had the same bug before the
move too.)

Cc: qemu-stable@nongnu.org
Fixes: f84734b87461 ("target/arm: Implement SMSTART, SMSTOP")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20250124162836.2332150-4-peter.maydell@linaro.org
(cherry picked from commit 1edc3d43f20df0d04f8d00b906ba19fed37512a5)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
target/arm/helper.c