]> git.ipfire.org Git - people/arne_f/kernel.git/commit
ALSA: core: Fix unexpected error at replacing user TLV
authorTakashi Iwai <tiwai@suse.de>
Tue, 22 Aug 2017 06:15:13 +0000 (08:15 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Aug 2017 08:19:22 +0000 (10:19 +0200)
commit099e57fcb03fb46ec707c9627ebc5e8b6f1ffcdc
tree7efc858b827fad4670fa7929c72fb3cf3d648d5f
parent07051c1754775c95306ef75730efbaa321a97523
ALSA: core: Fix unexpected error at replacing user TLV

commit 88c54cdf61f508ebcf8da2d819f5dfc03e954d1d upstream.

When user tries to replace the user-defined control TLV, the kernel
checks the change of its content via memcmp().  The problem is that
the kernel passes the return value from memcmp() as is.  memcmp()
gives a non-zero negative value depending on the comparison result,
and this shall be recognized as an error code.

The patch covers that corner-case, return 1 properly for the changed
TLV.

Fixes: 8aa9b586e420 ("[ALSA] Control API - more robust TLV implementation")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/core/control.c