]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rtlwifi: rtl8723ae: Fix missing break in switch statement
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 16 Apr 2019 15:17:22 +0000 (10:17 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 May 2019 17:43:44 +0000 (19:43 +0200)
commit09bc8f1114fbc7c35e0754f9aa07ac3272fa2463
tree8b3815687b9e7dfee0833eac7a8c73607ebe493a
parent946023a4b7ad1113f5f16d8dcfea83a0fa46a6ed
rtlwifi: rtl8723ae: Fix missing break in switch statement

commit 84242b82d81c54e009a2aaa74d3d9eff70babf56 upstream.

Add missing break statement in order to prevent the code from falling
through to case 0x1025, and erroneously setting rtlhal->oem_id to
RT_CID_819X_ACER when rtlefuse->eeprom_svid is equal to 0x10EC and
none of the cases in switch (rtlefuse->eeprom_smid) match.

This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.

Fixes: 238ad2ddf34b ("rtlwifi: rtl8723ae: Clean up the hardware info routine")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c