]> git.ipfire.org Git - thirdparty/glibc.git/commit
x86: Update _dl_tlsdesc_dynamic to preserve caller-saved registers
authorH.J. Lu <hjl.tools@gmail.com>
Mon, 26 Feb 2024 14:37:03 +0000 (06:37 -0800)
committerH.J. Lu <hjl.tools@gmail.com>
Wed, 28 Feb 2024 17:02:56 +0000 (09:02 -0800)
commit0aac205a814a8511e98d02b91a8dc908f1c53cde
treee9ad8dfa06abd2f6d9b521bb95e9b7cfaa0d7de7
parente6350be7e9cae8f71c96c1f06eab61b9acb227c8
x86: Update _dl_tlsdesc_dynamic to preserve caller-saved registers

Compiler generates the following instruction sequence for GNU2 dynamic
TLS access:

leaq tls_var@TLSDESC(%rip), %rax
call *tls_var@TLSCALL(%rax)

or

leal tls_var@TLSDESC(%ebx), %eax
call *tls_var@TLSCALL(%eax)

CALL instruction is transparent to compiler which assumes all registers,
except for EFLAGS and RAX/EAX, are unchanged after CALL.  When
_dl_tlsdesc_dynamic is called, it calls __tls_get_addr on the slow
path.  __tls_get_addr is a normal function which doesn't preserve any
caller-saved registers.  _dl_tlsdesc_dynamic saved and restored integer
caller-saved registers, but didn't preserve any other caller-saved
registers.  Add _dl_tlsdesc_dynamic IFUNC functions for FNSAVE, FXSAVE,
XSAVE and XSAVEC to save and restore all caller-saved registers.  This
fixes BZ #31372.

Add GLRO(dl_x86_64_runtime_resolve) with GLRO(dl_x86_tlsdesc_dynamic)
to optimize elf_machine_runtime_setup.
Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>
24 files changed:
elf/Makefile
elf/tst-gnu2-tls2.c [new file with mode: 0644]
elf/tst-gnu2-tls2.h [new file with mode: 0644]
elf/tst-gnu2-tls2mod0.c [new file with mode: 0644]
elf/tst-gnu2-tls2mod1.c [new file with mode: 0644]
elf/tst-gnu2-tls2mod2.c [new file with mode: 0644]
sysdeps/i386/dl-machine.h
sysdeps/i386/dl-tlsdesc-dynamic.h [new file with mode: 0644]
sysdeps/i386/dl-tlsdesc.S
sysdeps/x86/Makefile
sysdeps/x86/cpu-features.c
sysdeps/x86/dl-procinfo.c
sysdeps/x86/features-offsets.sym [moved from sysdeps/x86_64/features-offsets.sym with 89% similarity]
sysdeps/x86/sysdep.h
sysdeps/x86/tst-gnu2-tls2.c [new file with mode: 0644]
sysdeps/x86_64/Makefile
sysdeps/x86_64/dl-machine.h
sysdeps/x86_64/dl-procinfo.c
sysdeps/x86_64/dl-tlsdesc-dynamic.h [new file with mode: 0644]
sysdeps/x86_64/dl-tlsdesc.S
sysdeps/x86_64/dl-trampoline-save.h [new file with mode: 0644]
sysdeps/x86_64/dl-trampoline-state.h [new file with mode: 0644]
sysdeps/x86_64/dl-trampoline.S
sysdeps/x86_64/dl-trampoline.h