]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
vfio/mdev: Fix reference count leak in add_mdev_supported_type
authorQiushi Wu <wu000273@umn.edu>
Thu, 28 May 2020 02:01:09 +0000 (21:01 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Jun 2020 15:49:00 +0000 (17:49 +0200)
commit0b1d3a4d6d89ee33e69662dc06638370c83d22e5
treeae7f989945080e2f749e19d010bb9fb1f90f14d0
parent626fac3985a38fb6a1fd7265c100cf710f614809
vfio/mdev: Fix reference count leak in add_mdev_supported_type

[ Upstream commit aa8ba13cae3134b8ef1c1b6879f66372531da738 ]

kobject_init_and_add() takes reference even when it fails.
If this function returns an error, kobject_put() must be called to
properly clean up the memory associated with the object. Thus,
replace kfree() by kobject_put() to fix this issue. Previous
commit "b8eb718348b8" fixed a similar problem.

Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Kirti Wankhede <kwankhede@nvidia.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/vfio/mdev/mdev_sysfs.c