]> git.ipfire.org Git - thirdparty/qemu.git/commit
virtio: Call set_features during reset
authorAkihiko Odaki <akihiko.odaki@daynix.com>
Mon, 21 Apr 2025 12:17:20 +0000 (21:17 +0900)
committerMichael Tokarev <mjt@tls.msk.ru>
Thu, 15 May 2025 22:00:59 +0000 (01:00 +0300)
commit0b8c7cdeff6523dfb30aabd0c112ea3211a96159
treeffaf46eaee22308d5ab6e665b4d97d2dd6492157
parent0883bdd92e6ec2ee99e6dd6da95b45e9696744fd
virtio: Call set_features during reset

virtio-net expects set_features() will be called when the feature set
used by the guest changes to update the number of virtqueues but it is
not called during reset, which will clear all features, leaving the
queues added for VIRTIO_NET_F_MQ or VIRTIO_NET_F_RSS. Not only these
extra queues are visible to the guest, they will cause segmentation
fault during migration.

Call set_features() during reset to remove those queues for virtio-net
as we call set_status(). It will also prevent similar bugs for
virtio-net and other devices in the future.

Fixes: f9d6dbf0bf6e ("virtio-net: remove virtio queues if the guest doesn't support multiqueue")
Buglink: https://issues.redhat.com/browse/RHEL-73842
Cc: qemu-stable@nongnu.org
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20250421-reset-v2-1-e4c1ead88ea1@daynix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit 0caed25cd171c611781589b5402161d27d57229c)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/virtio/virtio.c