]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Fix matching for stateless/combined firmware
authorAndrea Bolognani <abologna@redhat.com>
Wed, 30 Jul 2025 15:35:23 +0000 (17:35 +0200)
committerAndrea Bolognani <abologna@redhat.com>
Wed, 24 Sep 2025 12:15:26 +0000 (14:15 +0200)
commit0b8daf9f68c31284a97919e847f2bee7c7046a6c
treeb4fd0ccc9b411b7c4c610b7f028481441558171b
parent20813b87b7425d66bd889221ca2fe52e6c01777c
qemu: Fix matching for stateless/combined firmware

The current code assumes that a stateless firmware has to be
explicitly requested by the user, and should never be picked
otherwise. This means that, for example, domains configured to
use SEV-SNP are forced to explicitly request for the firmware
to be stateless.

Additionally, we assume that only split firmware is suitable
for the stateful use case, whereas a combined firmware image
would also do the job.

As a result of these changes, the failing SEV-SNP test case
that was added recently passes, and so do the test cases
requesting read/write firmware.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Jim Fehlig <jfehlig@suse.com>
src/qemu/qemu_firmware.c
tests/qemuxmlconfdata/firmware-auto-efi-rw-pflash.x86_64-latest.args [new file with mode: 0644]
tests/qemuxmlconfdata/firmware-auto-efi-rw-pflash.x86_64-latest.err [deleted file]
tests/qemuxmlconfdata/firmware-auto-efi-rw-pflash.x86_64-latest.xml
tests/qemuxmlconfdata/firmware-auto-efi-rw.x86_64-latest.args [new file with mode: 0644]
tests/qemuxmlconfdata/firmware-auto-efi-rw.x86_64-latest.err [deleted file]
tests/qemuxmlconfdata/firmware-auto-efi-rw.x86_64-latest.xml
tests/qemuxmlconfdata/firmware-auto-efi-sev-snp.x86_64-latest+amdsev.args [new file with mode: 0644]
tests/qemuxmlconfdata/firmware-auto-efi-sev-snp.x86_64-latest+amdsev.err [deleted file]
tests/qemuxmlconfdata/firmware-auto-efi-sev-snp.x86_64-latest+amdsev.xml
tests/qemuxmlconftest.c