]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
fs/kernel_read_file: Remove FIRMWARE_EFI_EMBEDDED enum
authorKees Cook <keescook@chromium.org>
Fri, 2 Oct 2020 17:38:14 +0000 (10:38 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 1 Nov 2020 11:47:03 +0000 (12:47 +0100)
commit0baaa4a41f34ac057b714631d729ee63e0b46ad1
tree47fb699b68b7ea4f9804f3e76ab34c9e861ec035
parent5a91009aa24960736549df3eafc915152359cdbb
fs/kernel_read_file: Remove FIRMWARE_EFI_EMBEDDED enum

commit 06e67b849ab910a49a629445f43edb074153d0eb upstream.

The "FIRMWARE_EFI_EMBEDDED" enum is a "where", not a "what". It
should not be distinguished separately from just "FIRMWARE", as this
confuses the LSMs about what is being loaded. Additionally, there was
no actual validation of the firmware contents happening.

Fixes: e4c2c0ff00ec ("firmware: Add new platform fallback mechanism and firmware_request_platform()")
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Acked-by: Scott Branden <scott.branden@broadcom.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20201002173828.2099543-3-keescook@chromium.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/firmware_loader/fallback_platform.c
include/linux/fs.h