]> git.ipfire.org Git - thirdparty/iproute2.git/commit
iproute2: tc/m_pedit.c - remove dead code
authorMaciej Żenczykowski <maze@google.com>
Thu, 25 Jun 2015 09:03:02 +0000 (02:03 -0700)
committerStephen Hemminger <shemming@brocade.com>
Thu, 25 Jun 2015 12:52:06 +0000 (08:52 -0400)
commit0bbca0422f9779cc4eeaf70aa01dcad10d6ab076
treeed616cd428fd532e47e3278578a8ff5250c698d7
parent45b01c46d420ed790f7733763060af1725735c05
iproute2: tc/m_pedit.c - remove dead code

The initializers are simply not needed.

These if-blocks are outright dead code, because '0 > unsigned' is always
false, so only else clause triggers and regardless of which clause triggers
it only updates 'ind' which is later unconditionally written to before
being used anyway.

Otherwise we get errors from clang:

  m_pedit.c:166:8: error: comparison of 0 > unsigned expression is always false [-Werror,-Wtautological-compare]
    if (0 > tkey->off) {
        ~ ^ ~~~~~~~~~
  m_pedit.c:209:8: error: comparison of 0 > unsigned expression is always false [-Werror,-Wtautological-compare]
    if (0 > tkey->off) {
        ~ ^ ~~~~~~~~~
  2 errors generated.

Change-Id: I3c9e9092915088fc56f992e5df736851541a4458
tc/m_pedit.c