]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Remove assertion from PortalRunMulti
authorÁlvaro Herrera <alvherre@kurilemu.de>
Thu, 17 Jul 2025 15:40:22 +0000 (17:40 +0200)
committerÁlvaro Herrera <alvherre@kurilemu.de>
Thu, 17 Jul 2025 15:40:22 +0000 (17:40 +0200)
commit0c466f5e0b34bb9ddc53a422e9872b726f5f9620
tree8629996632f8b327905968499aabc01dc40cd512
parent7c6a3d838bae1b8b8a5a3caff8213855b9009ca2
Remove assertion from PortalRunMulti

We have an assertion to ensure that a command tag has been assigned by
the time we're done executing, but if we happen to execute a command
with no queries, the assertion would fail.  Per discussion, rather than
contort things to get a tag assigned, just remove the assertion.

Oversight in 2f9661311b83.  That commit also retained a comment that
explained logic that had been adjacent to it but diffused into various
places, leaving none apt to keep part of the comment.  Remove that part,
and rewrite what remains for extra clarity.

Bug: #18984
Backpatch-through: 13
Reported-by: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Michaël Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/18984-0f4778a6599ac3ae@postgresql.org
src/backend/tcop/pquery.c