]> git.ipfire.org Git - thirdparty/libvirt.git/commit
wireshark: Honor API change coming with 1.12 release
authorMichal Privoznik <mprivozn@redhat.com>
Fri, 4 Jul 2014 05:38:48 +0000 (07:38 +0200)
committerEric Blake <eblake@redhat.com>
Tue, 23 Dec 2014 13:36:55 +0000 (06:36 -0700)
commit0c6c56da7516055151c4dc12500b9565f4c344e5
tree22b4af814e185b22e24f83b2aeb8dac956685d2d
parent0f82996e30192f4ad855eb3f021f1079849f248e
wireshark: Honor API change coming with 1.12 release

https://bugs.gentoo.org/show_bug.cgi?id=508336

At wireshark, they have this promise to change public dissector APIs
only with minor version number change. Which they did when releasing
the version of 1.12.

Firstly, they've changed tvb_memdup() in
a0c53ffaa1bb46d8c9db2ec739401aa411c9790e so now it takes four arguments
instead of three. The new argument is placed at the very beginning of
the list of arguments and basically says the scope where we'd like to
allocate the memory. According to the documentation NULL should be the
default value.

Then, the tcp_dissect_pdus() signature changed too. Well, the function
that actually dissects reassembled packets as tcp_dissect_pdus()
reorder TCP packets into one big chunk and then calls a user function
to dissect the PDU at once. The change is dated back to
8081cf1d90397cbbb4404f9720595e1537ed5e14.

Then, WS_DLL_PUBLIC_NOEXTERN was replaced with WS_DLL_PUBLIC_DEF in
5d87a8c46171f572568db5a47c093423482e342f.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
(cherry picked from commit e74fa5702a238b2e8e42f84bba78e9beab9c28b3)
tools/wireshark/src/packet-libvirt.c
tools/wireshark/util/make-dissector-reg