]> git.ipfire.org Git - thirdparty/nftables.git/commit
tests: run-tests.sh: ensure non-zero exit when $failed != 0
authorŠtěpán Němec <snemec@redhat.com>
Wed, 20 Oct 2021 12:44:09 +0000 (14:44 +0200)
committerPhil Sutter <phil@nwl.cc>
Tue, 2 Nov 2021 21:00:38 +0000 (22:00 +0100)
commit0d64fc5d22c16c91bf6d80ee18190625b5dc57ad
tree206c2eee0b3f64cd816905d0dcacfa9d77f1767c
parenta39b9a7af845ddd97b78b285780c67042d24950d
tests: run-tests.sh: ensure non-zero exit when $failed != 0

POSIX [1] does not specify the behavior of `exit' with arguments
outside the 0-255 range, but what generally (bash, dash, zsh, OpenBSD
ksh, busybox) seems to happen is the shell exiting with status & 255
[2], which results in zero exit for certain non-zero arguments.

[1] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#exit
[2] https://git.savannah.gnu.org/cgit/bash.git/tree/builtins/common.c#n579

Fixes: 0c6592420586 ("tests: fix return codes")
Signed-off-by: Štěpán Němec <snemec@redhat.com>
Signed-off-by: Phil Sutter <phil@nwl.cc>
tests/build/run-tests.sh
tests/shell/run-tests.sh