]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ext4: fix data corruption caused by overlapping unaligned and aligned IO
authorLukas Czerner <lczerner@redhat.com>
Sat, 11 May 2019 01:45:33 +0000 (21:45 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 May 2019 05:39:56 +0000 (07:39 +0200)
commit0dc4c612e7937153de773f1e1b19297df0aeaa3d
tree25701c525b410390e8ba1ce8c42a038618239689
parentb02ae56d55d3e25497e4eb5a9b10f0b34e2b2e9e
ext4: fix data corruption caused by overlapping unaligned and aligned IO

commit 57a0da28ced8707cb9f79f071a016b9d005caf5a upstream.

Unaligned AIO must be serialized because the zeroing of partial blocks
of unaligned AIO can result in data corruption in case it's overlapping
another in flight IO.

Currently we wait for all unwritten extents before we submit unaligned
AIO which protects data in case of unaligned AIO is following overlapping
IO. However if a unaligned AIO is followed by overlapping aligned AIO we
can still end up corrupting data.

To fix this, we must make sure that the unaligned AIO is the only IO in
flight by waiting for unwritten extents conversion not just before the
IO submission, but right after it as well.

This problem can be reproduced by xfstest generic/538

Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/file.c