]> git.ipfire.org Git - thirdparty/lxc.git/commit
Revert "api: ->save_config() doesn't need to create container dir"
authorStéphane Graber <stgraber@ubuntu.com>
Tue, 30 Nov 2021 22:39:34 +0000 (17:39 -0500)
committerStéphane Graber <stgraber@ubuntu.com>
Wed, 1 Dec 2021 15:38:58 +0000 (10:38 -0500)
commit0dd3258bddc1eb55fe2d4f4bbe8bf629cdff87eb
tree73398e47111464e135fc4770aefa58790354ccdc
parent93edd510ae9980b3ea9fe6d68bff8df7aa0169a7
Revert "api: ->save_config() doesn't need to create container dir"

This reverts commit 2fde07c3990fe09925699da5d9a1762eb279c497.

We need to investigate this in more detail but this commit is breaking
LXD, causing startup to fail with:

lxc foo 20211130202833.906 INFO     conf - conf.c:run_script_argv:336 - Executing script "/bin/mount -t shiftfs -o passthrough=3 "/lxc-ci/build/tmp.WemmpzWGYz/go/src/github.com/lxc/lxd/test/tmp.Cli/0To/containers/foo/rootfs" "/lxc-ci/build/tmp.WemmpzWGYz/go/src/github.com/lxc/lxd/test/tmp.Cli/0To/containers/foo/rootfs"" for container "foo"
lxc foo 20211130202833.912 ERROR    conf - conf.c:run_buffer:321 - Script exited with status 32
lxc foo 20211130202833.912 ERROR    conf - conf.c:lxc_setup_rootfs_prepare_root:3947 - Failed to run pre-mount hooks
lxc foo 20211130202833.912 ERROR    conf - conf.c:lxc_setup:4317 - Failed to setup rootfs
lxc foo 20211130202833.912 ERROR    start - start.c:do_start:1275 - Failed to setup container "foo"

Not entirely sure why we're seeing things blow up as the directory
definitely exists (and contains a valid rootfs) but this was caused by
today's liblxc update.

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
src/lxc/lxccontainer.c