]> git.ipfire.org Git - thirdparty/gcc.git/commit
testsuite: analyzer: expect alignment warning with -fshort-enums
authorAlexandre Oliva <oliva@adacore.com>
Mon, 20 Nov 2023 08:14:31 +0000 (05:14 -0300)
committerAlexandre Oliva <oliva@gnu.org>
Mon, 20 Nov 2023 08:14:31 +0000 (05:14 -0300)
commit0e0e3420dfe1d302145b4eb3bbf311a4f39eeced
tree919450add85a42f3dab122b5732589cc68957e17
parent69741355e6dbcf64408b77dca6a2f863ccecdae9
testsuite: analyzer: expect alignment warning with -fshort-enums

On targets that have -fshort-enums enabled by default, the type casts
in the pr108251 analyzer tests warn that the byte-aligned enums may
not be sufficiently aligned to be a struct connection *.  The function
can't know better, the warning is reasonable, the code doesn't
expected enums to be shorter and less aligned than the struct.

Rather than use -fno-short-enums, I decided to embrace the warning on
targets that have short_enums enabled by default.

However, C++ doesn't issue the warning, because even with
-fshort-enums, enumeration types are not TYPE_PACKED, and the
expression is not sufficiently simplified by the C++ front-end for
check_and_warn_address_or_pointer_of_packed_member to identify the
insufficiently aligned pointer.  So don't expect the warning there.

for  gcc/testsuite/ChangeLog

* c-c++-common/analyzer/null-deref-pr108251-smp_fetch_ssl_fc_has_early-O2.c:
Expect "unaligned pointer value" warning on short_enums
targets, but not in c++.
* c-c++-common/analyzer/null-deref-pr108251-smp_fetch_ssl_fc_has_early.c:
Likewise.
gcc/testsuite/c-c++-common/analyzer/null-deref-pr108251-smp_fetch_ssl_fc_has_early-O2.c
gcc/testsuite/c-c++-common/analyzer/null-deref-pr108251-smp_fetch_ssl_fc_has_early.c