]> git.ipfire.org Git - thirdparty/qemu.git/commit
target/arm: Fix handling of LDAPR/STLR with negative offset
authorPeter Maydell <peter.maydell@linaro.org>
Tue, 16 Jul 2024 10:30:32 +0000 (11:30 +0100)
committerMichael Tokarev <mjt@tls.msk.ru>
Tue, 27 Aug 2024 19:09:54 +0000 (22:09 +0300)
commit0e7ed3f40f5c5eebe3dbf9d7e97af5348a31fc19
treec7fedab060864f4d8527668f146848197e053bc6
parentd275bfbaa54c518e53c79d0d37569c0c2c446c5d
target/arm: Fix handling of LDAPR/STLR with negative offset

When we converted the LDAPR/STLR instructions to decodetree we
accidentally introduced a regression where the offset is negative.
The 9-bit immediate field is signed, and the old hand decoder
correctly used sextract32() to get it out of the insn word,
but the ldapr_stlr_i pattern in the decode file used "imm:9"
instead of "imm:s9", so it treated the field as unsigned.

Fix the pattern to treat the field as a signed immediate.

Cc: qemu-stable@nongnu.org
Fixes: 2521b6073b7 ("target/arm: Convert LDAPR/STLR (imm) to decodetree")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2419
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20240709134504.3500007-2-peter.maydell@linaro.org
(cherry picked from commit 5669d26ec614b3f4c56cf1489b9095ed327938b1)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
target/arm/tcg/a64.decode