]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Fix invalid read in virCgroupGetValueStr
authorJán Tomko <jtomko@redhat.com>
Wed, 26 Jun 2013 11:07:24 +0000 (13:07 +0200)
committerJán Tomko <jtomko@redhat.com>
Mon, 1 Jul 2013 11:43:59 +0000 (13:43 +0200)
commit0eba4bcaad5b96297be2f3da6b66bec7cb83bc59
tree1ac67777619d9b7573bb0f1faf44b0da1aba6b3a
parent81307698c11387304dae46af56983cc800741946
Fix invalid read in virCgroupGetValueStr

Don't check for '\n' at the end of file if zero bytes were read.

Found by valgrind:
==404== Invalid read of size 1
==404==    at 0x529B09F: virCgroupGetValueStr (vircgroup.c:540)
==404==    by 0x529AF64: virCgroupMoveTask (vircgroup.c:1079)
==404==    by 0x1EB475: qemuSetupCgroupForEmulator (qemu_cgroup.c:1061)
==404==    by 0x1D9489: qemuProcessStart (qemu_process.c:3801)
==404==    by 0x18557E: qemuDomainObjStart (qemu_driver.c:5787)
==404==    by 0x190FA4: qemuDomainCreateWithFlags (qemu_driver.c:5839)

Introduced by 0d0b409.

https://bugzilla.redhat.com/show_bug.cgi?id=978356
(cherry picked from commit 306c49ffd56a1c72b1892d50f2a75531c62f4a1d)
src/util/vircgroup.c