]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
gdb/testsuite: Restore libc_has_debug_info's less strict behaviour
authorThiago Jung Bauermann <thiago.bauermann@linaro.org>
Tue, 30 Apr 2024 01:53:25 +0000 (22:53 -0300)
committerThiago Jung Bauermann <thiago.bauermann@linaro.org>
Thu, 23 May 2024 03:55:45 +0000 (00:55 -0300)
commit100318bcfda243f04cda3c29e8873c5710a1688a
tree65eb725004ba3cee9a190c58d780b2e45e1908c5
parentfc12b44ec0e07e036155092ddfffe0c237415611
gdb/testsuite: Restore libc_has_debug_info's less strict behaviour

The code that was factored out from gdb.base/relativedebug.exp assumed that
libc has debug info and only determined that it doesn't if it saw a specific
message from GDB to that effect.  In the process of factoring it into a
require predicate, I made it stricter by trying to make a specific
determination of whether or not debug info is available.

Pedro noticed that "It'll disable the testcase on systems that link with
their libc statically (even if has debug info), or systems that name their
libc something else."  Which is something I hadn't considered.

This patch returns libc_has_debug_info to the original behaviour.

Also, remove a verbose message that is redundant with the $message
variable.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31700
Approved-By: Tom Tromey <tom@tromey.com>
gdb/testsuite/lib/gdb.exp