]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
vsock: lock down child_ns_mode as write-once
authorBobby Eshleman <bobbyeshleman@meta.com>
Mon, 23 Feb 2026 22:38:33 +0000 (14:38 -0800)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 26 Feb 2026 10:10:03 +0000 (11:10 +0100)
commit102eab95f025b4d3f3a6c0a858400aca2af2fe52
tree4d0fab584ded0214cbfc94a730c755dadffdfc3b
parenta382a34276cb94d1cdc620b622dd85c55589a166
vsock: lock down child_ns_mode as write-once

Two administrator processes may race when setting child_ns_mode as one
process sets child_ns_mode to "local" and then creates a namespace, but
another process changes child_ns_mode to "global" between the write and
the namespace creation. The first process ends up with a namespace in
"global" mode instead of "local". While this can be detected after the
fact by reading ns_mode and retrying, it is fragile and error-prone.

Make child_ns_mode write-once so that a namespace manager can set it
once and be sure it won't change. Writing a different value after the
first write returns -EBUSY. This applies to all namespaces, including
init_net, where an init process can write "local" to lock all future
namespaces into local mode.

Fixes: eafb64f40ca4 ("vsock: add netns to vsock core")
Suggested-by: Daan De Meyer <daan.j.demeyer@gmail.com>
Suggested-by: Stefano Garzarella <sgarzare@redhat.com>
Co-developed-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Link: https://patch.msgid.link/20260223-vsock-ns-write-once-v3-2-c0cde6959923@meta.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
include/net/af_vsock.h
include/net/netns/vsock.h
net/vmw_vsock/af_vsock.c