]> git.ipfire.org Git - thirdparty/linux.git/commit
hostfs: Add const qualifier to host_root in hostfs_fill_super()
authorNathan Chancellor <nathan@kernel.org>
Tue, 11 Jun 2024 19:58:41 +0000 (12:58 -0700)
committerChristian Brauner <brauner@kernel.org>
Thu, 13 Jun 2024 12:12:16 +0000 (14:12 +0200)
commit104eef133fd9c17e4dc28bf43f592a86f26d8a59
treeae8331ccca9dca600293abf5872134a93b93912a
parentcd140ce9f611a5e9d2a5989a282b75e55c71dab3
hostfs: Add const qualifier to host_root in hostfs_fill_super()

After the recent conversion to the new mount API, there is a warning
when building hostfs (which may be upgraded to an error via
CONFIG_WERROR=y):

  fs/hostfs/hostfs_kern.c: In function 'hostfs_fill_super':
  fs/hostfs/hostfs_kern.c:942:27: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    942 |         char *host_root = fc->source;
        |                           ^~

Add the 'const' qualifier, as host_root will not be modified after its
assignment. Move the assignment to keep the existing reverse Christmas
tree order intact.

Fixes: cd140ce9f611 ("hostfs: convert hostfs to use the new mount API")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20240611-hostfs-fix-mount-api-conversion-v1-1-ef75bbc77f44@kernel.org
Acked-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/hostfs/hostfs_kern.c