]> git.ipfire.org Git - thirdparty/public-inbox.git/commit
http: don't requeue if using write buffer
authorEric Wong <e@80x24.org>
Thu, 4 Jul 2024 02:20:55 +0000 (02:20 +0000)
committerEric Wong <e@80x24.org>
Thu, 4 Jul 2024 06:52:08 +0000 (06:52 +0000)
commit112fbeed50629c2b366db24e5ccb70103b759821
tree071d463f49f4ad67df0cfc26d21d295580021684
parent8289957a008160348612d79fd0564a95636024dd
http: don't requeue if using write buffer

The write buffering will already be processed inside
->event_step, so requeue will cause a needless read(2) outside
of epoll_wait/kevent(2) readiness notifications.

This ought to avoid problems in case of pipelined connections,
but those aren't possible behind a reverse proxy and AFAIK most
HTTP clients don't do pipelining.  This bug was only noticed via
strace while searching for extra syscalls, and not from
real-world use.
lib/PublicInbox/HTTP.pm