]> git.ipfire.org Git - thirdparty/linux.git/commit
net/tcp: Don't add key with non-matching VRF on connected sockets
authorDmitry Safonov <dima@arista.com>
Mon, 4 Dec 2023 19:00:43 +0000 (19:00 +0000)
committerPaolo Abeni <pabeni@redhat.com>
Wed, 6 Dec 2023 11:36:55 +0000 (12:36 +0100)
commit12083d728213285c2d4347fa0ed3b556449703ce
tree608cbf50cf5bfa59c7c42ed849d642bcce0938c6
parent965c00e4ea2e4df986ecd73c2fe9d3a00a2858db
net/tcp: Don't add key with non-matching VRF on connected sockets

If the connection was established, don't allow adding TCP-AO keys that
don't match the peer. Currently, there are checks for ip-address
matching, but L3 index check is missing. Add it to restrict userspace
shooting itself somewhere.

Yet, nothing restricts the CAP_NET_RAW user from trying to shoot
themselves by performing setsockopt(SO_BINDTODEVICE) or
setsockopt(SO_BINDTOIFINDEX) over an established TCP-AO connection.
So, this is just "minimum effort" to potentially save someone's
debugging time, rather than a full restriction on doing weird things.

Fixes: 248411b8cb89 ("net/tcp: Wire up l3index to TCP-AO")
Signed-off-by: Dmitry Safonov <dima@arista.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/ipv4/tcp_ao.c