]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix race in SSI interaction with gin fast path.
authorThomas Munro <tmunro@postgresql.org>
Mon, 3 Jul 2023 04:20:01 +0000 (16:20 +1200)
committerThomas Munro <tmunro@postgresql.org>
Mon, 3 Jul 2023 21:04:35 +0000 (09:04 +1200)
commit12529028a4e55eb0500477d2589eec625466facf
tree7717e9947b582401c2d5c0ea57f7000c736a3e60
parentd03d9a2614fd58d4a9e90107f1700952333ce2a2
Fix race in SSI interaction with gin fast path.

The ginfast.c code previously checked for conflicts in before locking
the relevant buffer, leaving a window where a RW conflict could be
missed.  Re-order.

There was also a place where buffer ID and block number were confused
while trying to predicate-lock a page, noted by visual inspection.

Back-patch to all supported releases.  Fixes one more problem discovered
with the reproducer from bug #17949, in this case when Dmitry tried
other index types.

Reported-by: Artem Anisimov <artem.anisimov.255@gmail.com>
Reported-by: Dmitry Dolgov <9erthalion6@gmail.com>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/17949-a0f17035294a55e2%40postgresql.org
src/backend/access/gin/ginfast.c
src/backend/access/gin/ginget.c