]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: command: Drop formatting of 'media=cdrom' from -drive
authorPeter Krempa <pkrempa@redhat.com>
Mon, 28 Jan 2019 16:18:56 +0000 (17:18 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 8 Feb 2019 07:48:33 +0000 (08:48 +0100)
commit1328a830ce4834bbcab7aad210de5fc423ec8a13
tree2567af7167124f529f75cab8605bd9998acae72f
parentea13c12940b7ebcffebd409293b0bfe88e315830
qemu: command: Drop formatting of 'media=cdrom' from -drive

For SCSI, IDE, and AHCI cdroms the appropriate device types which select
the correct media are used. In qemu there's one other code path that
looks at -drive media=cdrom in the XEN pv code. Thankfully we don't
support it with qemu (see qemuBuildDiskDeviceStr). All other devices
ignore it as the comment states, thus we can drop that code.

The test fallout is expectedly only in the test added for uncommon cdrom
types.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
src/qemu/qemu_command.c
tests/qemuxml2argvdata/disk-cdrom-bus-other.x86_64-latest.args