]> git.ipfire.org Git - people/arne_f/kernel.git/commit
iio: dac: ad5624r: Fix incorrect handling of an optional regulator.
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 27 Jun 2021 16:32:37 +0000 (17:32 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 09:41:24 +0000 (11:41 +0200)
commit1382eae1b1330369ad40e2e96f609a362a674550
tree8980c7a14050185a84c1366b6e6e341722dce53e
parentc767ab61349798268a54e37c5d2d282b90512703
iio: dac: ad5624r: Fix incorrect handling of an optional regulator.

[ Upstream commit 97683c851f9cdbd3ea55697cbe2dcb6af4287bbd ]

The naming of the regulator is problematic.  VCC is usually a supply
voltage whereas these devices have a separate VREF pin.

Secondly, the regulator core might have provided a stub regulator if
a real regulator wasn't provided. That would in turn have failed to
provide a voltage when queried. So reality was that there was no way
to use the internal reference.

In order to avoid breaking any dts out in the wild, make sure to fallback
to the original vcc naming if vref is not available.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reported-by: kernel test robot <lkp@intel.com>
Acked-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20210627163244.1090296-9-jic23@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iio/dac/ad5624r_spi.c