]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/ssi/aspeed_smc: Fix incorrect FMC_WDT2 register read on AST1030
authorJamin Lin <jamin_lin@aspeedtech.com>
Mon, 4 Aug 2025 01:46:33 +0000 (09:46 +0800)
committerCédric Le Goater <clg@redhat.com>
Mon, 4 Aug 2025 07:07:38 +0000 (09:07 +0200)
commit13ed972b4ce57198914a37217251d30fbec20e41
treebbfe7d4c80513ac8976a4cbbbbdcc3f6fd392061
parentd63961f957ffaa586b166846f2c6a580923b08f6
hw/ssi/aspeed_smc: Fix incorrect FMC_WDT2 register read on AST1030

On AST1030, reading the FMC_WDT2 register always returns 0xFFFFFFFF.
This issue is due to the aspeed_smc_read function, which checks for the
ASPEED_SMC_FEATURE_WDT_CONTROL feature. Since AST1030 was missing this
feature flag, the read operation fails and returns -1.

To resolve this, add the WDT_CONTROL feature to AST1030's feature set
so that FMC_WDT2 can be correctly accessed by firmware.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Fixes: 2850df6a81bcdc2e063dfdd56751ee2d11c58030 ("aspeed/smc: Add AST1030 support ")
Link: https://lore.kernel.org/qemu-devel/20250804014633.512737-1-jamin_lin@aspeedtech.com
Signed-off-by: Cédric Le Goater <clg@redhat.com>
hw/ssi/aspeed_smc.c