]> git.ipfire.org Git - thirdparty/qemu.git/commit
migration: qmp_migrate(): keep working after syntax error
authorLuiz Capitulino <lcapitulino@redhat.com>
Mon, 30 Dec 2013 03:39:58 +0000 (22:39 -0500)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Fri, 21 Feb 2014 06:34:40 +0000 (00:34 -0600)
commit15a14f2eeb76f82b742d009cf320972e7d173f49
tree1fefe4e6a07fbee9fc4908f9c68fe76bbb3f9996
parent88d08de7e5d08bfa44613e492cd64f8b3974d62e
migration: qmp_migrate(): keep working after syntax error

If a user or QMP client enter a bad syntax for the migrate
command in QMP/HMP, then the migrate command will never succeed
from that point on.

For example, if you enter:

(qemu) migrate tcp;0:4444
migrate: Parameter 'uri' expects a valid migration protocol

Then the migrate command will always fail from now on:

(qemu) migrate tcp:0:4444
migrate: There's a migration process in progress

The problem is that qmp_migrate() sets the migration status to
MIG_STATE_SETUP and doesn't reset it on syntax error. This bug
was introduced by commit 29ae8a4133082e16970c9d4be09f4b6a15034617.

Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
(cherry picked from commit c950114286ea358a93ce632db0421945e1008395)

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
migration.c