]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/core/machine: Fix -machine dumpdtb=file.dtb
authorJoel Stanley <joel@jms.id.au>
Tue, 1 Apr 2025 04:15:08 +0000 (14:45 +1030)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 8 Apr 2025 18:46:07 +0000 (20:46 +0200)
commit15a9fe6e35369d6e488233f689a3dbdd7a525546
treedd7802bb5fac9f0ec542e29ffe5e3b70ac5dcf68
parenta7a05f5f6a4085afbede315e749b1c67e78c966b
hw/core/machine: Fix -machine dumpdtb=file.dtb

In commit 8fd2518ef2f8 ("hw: Centralize handling of -machine dumpdtb
option") the call to dump was moved with respect to the init of the
machine.  This resulted in the device tree missing parts of the machine
description, depending on how they construct their device tree.

The arm virt machine is missing some PSCI nodes, while the riscv one
is missing most of its content.

Move the dump to after the notifiers have been run, allowing
virt_machine_done to be called and the device tree to be fully
populated.

Fixes: 8fd2518ef2f8 ("hw: Centralize handling of -machine dumpdtb option")
Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20250401041509.719153-1-joel@jms.id.au>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
hw/core/machine.c