]> git.ipfire.org Git - thirdparty/libarchive.git/commit
Skip 0-length ACL fields
authorDaniel Axtens <dja@axtens.net>
Tue, 4 Dec 2018 03:29:42 +0000 (14:29 +1100)
committerDaniel Axtens <dja@axtens.net>
Tue, 11 Dec 2018 02:58:11 +0000 (13:58 +1100)
commit15bf44fd2c1ad0e3fd87048b3fcc90c4dcff1175
treeff6e8214fcfb31ee79012706607a52feeec9b81e
parentbfcfe6f04ed20db2504db8a254d1f40a1d84eb28
Skip 0-length ACL fields

Currently, it is possible to create an archive that crashes bsdtar
with a malformed ACL:

Program received signal SIGSEGV, Segmentation fault.
archive_acl_from_text_l (acl=<optimised out>, text=0x7e2e92 "", want_type=<optimised out>, sc=<optimised out>) at libarchive/archive_acl.c:1726
1726 switch (*s) {
(gdb) p n
$1 = 1
(gdb) p field[n]
$2 = {start = 0x0, end = 0x0}

Stop this by checking that the length is not zero before beginning
the switch statement.

I am pretty sure this is the bug mentioned in the qsym paper [1],
and I was able to replicate it with a qsym + AFL + afl-rb setup.

[1] https://www.usenix.org/conference/usenixsecurity18/presentation/yun
libarchive/archive_acl.c