]> git.ipfire.org Git - thirdparty/qemu.git/commit
nbd: Allow unmap and fua during write zeroes
authorEric Blake <eblake@redhat.com>
Thu, 17 Nov 2016 20:13:54 +0000 (14:13 -0600)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 22 Nov 2016 22:26:51 +0000 (23:26 +0100)
commit169407e1f7c9afee1cdac0ee6ad0b8d5e361c4dd
treeb8c0eff97a23f1f62682faad9ccaee32cf28f564
parentc2a85316902e67530da9d6548139fcce73c0cac6
nbd: Allow unmap and fua during write zeroes

Commit fa778fff wired up support to send the NBD_CMD_WRITE_ZEROES,
but forgot to inform the block layer that FUA unmapping of zeroes is
supported.  Without BDRV_REQ_MAY_UNMAP listed as a supported flag,
the block layer will always insist on the NBD layer passing
NBD_CMD_FLAG_NO_HOLE, resulting in the server always allocating
things even when it was desired to let the server punch holes.
Similarly, failing to set BDRV_REQ_FUA means that the client may
send unnecessary NBD_CMD_FLUSH when it could have instead used the
NBD_CMD_FLAG_FUA bit.

CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1479413642-22463-2-git-send-email-eblake@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
block/nbd-client.c