]> git.ipfire.org Git - thirdparty/libvirt.git/commit
bhyve: support 'isa' controller for LPC
authorRoman Bogorodskiy <bogorodskiy@gmail.com>
Sun, 17 Feb 2019 13:04:00 +0000 (17:04 +0400)
committerRoman Bogorodskiy <bogorodskiy@gmail.com>
Mon, 21 Sep 2020 16:03:00 +0000 (20:03 +0400)
commit16a2882350a85afdb0574a03117b36daac53750d
tree063946fd8d3fccd733de1c6111811e4750a63023
parentf787df99477005ecc2ea4a7976cea47a012723ee
bhyve: support 'isa' controller for LPC

Support modeling of the 'isa' controller for bhyve. User can manually
define any PCI slot for the 'isa' controller, including PCI slot 1,
but other devices are not allowed to use this address.

When domain configuration requires the 'isa' controller to be present,
automatically add it on domain post-parse stage.

Now, as this controller is always available when needed, it's not
necessary to implicitly add it to the bhyve command line, so remove
bhyveBuildLPCArgStr().

Also, make bhyveDomainDefNeedsISAController() static as it's no longer
used outside of bhyve_domain.c.

As more than one ISA controller is not supported by bhyve,
and multiple controllers with the same index are forbidden,
so forbid ISA controllers with non-zero index for bhyve.

Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
39 files changed:
src/bhyve/bhyve_command.c
src/bhyve/bhyve_device.c
src/bhyve/bhyve_domain.c
src/bhyve/bhyve_domain.h
tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-1.args [new file with mode: 0644]
tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-1.ldargs [new file with mode: 0644]
tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-1.xml [new file with mode: 0644]
tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-31.args [new file with mode: 0644]
tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-31.ldargs [new file with mode: 0644]
tests/bhyvexml2argvdata/bhyvexml2argv-addr-isa-controller-on-slot-31.xml [new file with mode: 0644]
tests/bhyvexml2argvdata/bhyvexml2argv-addr-non-isa-controller-on-slot-1.xml [new file with mode: 0644]
tests/bhyvexml2argvdata/bhyvexml2argv-console.args
tests/bhyvexml2argvdata/bhyvexml2argv-isa-controller.args [new file with mode: 0644]
tests/bhyvexml2argvdata/bhyvexml2argv-isa-controller.ldargs [new file with mode: 0644]
tests/bhyvexml2argvdata/bhyvexml2argv-isa-controller.xml [new file with mode: 0644]
tests/bhyvexml2argvdata/bhyvexml2argv-isa-multiple-controllers.xml [new file with mode: 0644]
tests/bhyvexml2argvdata/bhyvexml2argv-serial-grub-nocons.args
tests/bhyvexml2argvdata/bhyvexml2argv-serial-grub.args
tests/bhyvexml2argvdata/bhyvexml2argv-serial.args
tests/bhyvexml2argvdata/bhyvexml2argv-uefi.args
tests/bhyvexml2argvdata/bhyvexml2argv-vnc-autoport.args
tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf-io.args
tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf-off.args
tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf-on.args
tests/bhyvexml2argvdata/bhyvexml2argv-vnc.args
tests/bhyvexml2argvtest.c
tests/bhyvexml2xmloutdata/bhyvexml2xmlout-addr-isa-controller-on-slot-1.xml [new file with mode: 0644]
tests/bhyvexml2xmloutdata/bhyvexml2xmlout-addr-isa-controller-on-slot-31.xml [new file with mode: 0644]
tests/bhyvexml2xmloutdata/bhyvexml2xmlout-console.xml
tests/bhyvexml2xmloutdata/bhyvexml2xmlout-isa-controller.xml [new file with mode: 0644]
tests/bhyvexml2xmloutdata/bhyvexml2xmlout-serial-grub-nocons.xml
tests/bhyvexml2xmloutdata/bhyvexml2xmlout-serial-grub.xml
tests/bhyvexml2xmloutdata/bhyvexml2xmlout-serial.xml
tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-autoport.xml
tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-vgaconf-io.xml
tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-vgaconf-off.xml
tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-vgaconf-on.xml
tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc.xml
tests/bhyvexml2xmltest.c