]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
xfs_admin: don't add '=1' when building repair command line for -O
authorDarrick J. Wong <djwong@kernel.org>
Fri, 12 Mar 2021 18:57:27 +0000 (13:57 -0500)
committerEric Sandeen <sandeen@sandeen.net>
Fri, 12 Mar 2021 18:57:27 +0000 (13:57 -0500)
commit16c64512bbc36e433e31659d8c1348bcb5b36009
tree274b03d52df795d80670c0472cb0035d8af72bd9
parent533034dcedd36eb01e4900d3e78ec88fbbc62391
xfs_admin: don't add '=1' when building repair command line for -O

Geert Hendrickx reported an inconsistency between the xfs_admin manpage
and its behavior -- the documentation says that users must provide the
status explicitly, but the script injects '=1' anyway.  While this seems
to work with the glibc getsubopt, it's a bit ugly and isn't consistent
with the docs.

So, get rid of that extra two bytes.

Reported-by: Geert Hendrickx <geert@hendrickx.be>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
db/xfs_admin.sh