]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
x86/mm: Stop prefetching current->mm->mmap_lock on page faults
authorMateusz Guzik <mjguzik@gmail.com>
Tue, 1 Apr 2025 14:35:20 +0000 (16:35 +0200)
committerIngo Molnar <mingo@kernel.org>
Tue, 1 Apr 2025 20:48:56 +0000 (22:48 +0200)
commit1701771d3069fbee154ca48e882e227fdcfbb583
treec32762488e57a5a7f4f04b335fef8250fb55c9c9
parent2b00d9031e42eabc8d32847d231ef48b8be0373d
x86/mm: Stop prefetching current->mm->mmap_lock on page faults

The prefetchw() dates back decades and the fundamental notion of doing
something like this on a lock is shady.

Moreover, for a few years now in the fast path faults are handled with RCU
+ per-vma locking, hopefully not even looking at the lock to begin with.

As such just remove it.

I did not see a point benchmarking this. Given that it is not expected
to be looked at by default justifies not doing the prefetch.

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@surriel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: https://lore.kernel.org/r/20250401143520.1113572-1-mjguzik@gmail.com
arch/x86/mm/fault.c