]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Provide a more detailed error message for Query.join()
authorRamonWill <ramonwilliams@hotmail.co.uk>
Tue, 25 Aug 2020 00:14:15 +0000 (20:14 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Mon, 31 Aug 2020 23:01:15 +0000 (19:01 -0400)
commit17090c004e19afab35c837bf880ea5b328e1fb56
tree7c938e4f1b5e3ccbbe1081806509102430a0e2e9
parentc3d74b3bef84f630993f307012003832cec232e7
Provide a more detailed error message for Query.join()

An :class:`.ArgumentError` with more detail is now raised if the target
parameter for :meth:`_query.Query.join` is set to an unmapped object.
Prior to this change a less detailed ``AttributeError`` was raised.
Pull request courtesy Ramon Williams.

Fixes: #4428
Closes: #5452
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/5452
Pull-request-sha: b148df547037e9a254fe331eff8e922c78426261

Change-Id: I873453d1fdb651178216aac698baac63ae5a94e8
doc/build/changelog/unreleased_13/4428.rst [new file with mode: 0644]
lib/sqlalchemy/orm/context.py
test/orm/test_joins.py