]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix race condition in pg_ctl reading postmaster.pid.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Sat, 13 Oct 2012 09:48:14 +0000 (12:48 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 15 Oct 2012 07:51:50 +0000 (10:51 +0300)
commit17901b013709a0e46056b20001ee620016a286c6
tree0e261e4feb2eba1b4a56e24510386053c3fbb6ac
parent47232d7347791a1f9220a1daf3ccd2953f23bd08
Fix race condition in pg_ctl reading postmaster.pid.

If postmaster changed postmaster.pid while pg_ctl was reading it, pg_ctl
could overrun the buffer it allocated for the file. Fix by reading the
whole file to memory with one read() call.

initdb contains an identical copy of the readfile() function, but the files
that initdb reads are static, not modified concurrently. Nevertheless, add
a simple bounds-check there, if only to silence static analysis tools.

Per report from Dave Vitek. Backpatch to all supported branches.
src/bin/initdb/initdb.c
src/bin/pg_ctl/pg_ctl.c