]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/i386/amd_iommu: Fix maybe-uninitialized error with GCC 12
authorPaolo Bonzini <pbonzini@redhat.com>
Mon, 21 Mar 2022 14:30:18 +0000 (15:30 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 21 Mar 2022 14:57:47 +0000 (15:57 +0100)
commit17e6ffa6a5d2674cb2ebfd967d28b1048261d977
treecc2609a282f42a92d5cc7c082f8cfcff8c7b5903
parent3ec5ad40081b14af28496198b4d08dbe13386790
hw/i386/amd_iommu: Fix maybe-uninitialized error with GCC 12

Be more explicit that the loop must roll at least once.  Avoids the
following warning:

  FAILED: libqemu-x86_64-softmmu.fa.p/hw_i386_amd_iommu.c.o
  In function 'pte_get_page_mask',
      inlined from 'amdvi_page_walk' at hw/i386/amd_iommu.c:945:25,
      inlined from 'amdvi_do_translate' at hw/i386/amd_iommu.c:989:5,
      inlined from 'amdvi_translate' at hw/i386/amd_iommu.c:1038:5:
  hw/i386/amd_iommu.c:877:38: error: 'oldlevel' may be used uninitialized [-Werror=maybe-uninitialized]
    877 |     return ~((1UL << ((oldlevel * 9) + 3)) - 1);
        |                      ~~~~~~~~~~~~~~~~^~~~
  hw/i386/amd_iommu.c: In function 'amdvi_translate':
  hw/i386/amd_iommu.c:906:41: note: 'oldlevel' was declared here
    906 |     unsigned level, present, pte_perms, oldlevel;
        |                                         ^~~~~~~~
  cc1: all warnings being treated as errors

Having:

  $ gcc --version
  gcc (Debian 12-20220313-1) 12.0.1 20220314 (experimental)

Reported-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/i386/amd_iommu.c